Remove TestExpectations for crbug.com/502427 + fix tests

Remove TestExpectations for crbug.com/502427 + fix tests

BUG=502427, v8:4197
R=
LOG=N

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197652

[caitp (gmail), 2015-06-20 09:59:10]

Patchset #2 (id:20001) has been deleted

[caitp (gmail), 2015-06-20 09:59:18]

Patchset #1 (id:1) has been deleted

[caitp (gmail), 2015-06-20 20:31:10]

caitpotter88@gmail.com changed reviewers:
+ arv@chromium.org

[caitp (gmail), 2015-06-20 20:31:10]

PTAL thanks

[caitp (gmail), 2015-06-20 20:31:42]

caitpotter88@gmail.com changed reviewers:
+ jsbell@chromium.org

[arv (Not doing code reviews), 2015-06-21 04:15:33]

In this case where the test is just wrong we should update the test too. We
should only keep FAIL in the result when we expect/hope to fix our behavior
in the future.
On Jun 20, 2015 4:31 PM, <caitpotter88@gmail.com> wrote:

> Reviewers: arv,
>
> Message:
> PTAL thanks
>
> Description:
> Remove TestExpectations for crbug.com/502427 + fix tests
>
> BUG=502427, v8:4197
> R=
> LOG=N
>
> Please review this at https://codereview.chromium.org/1200523003/
>
> Base URL: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+4, -7 lines):
>   M LayoutTests/TestExpectations
>   M LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
>   M LayoutTests/fast/js/cyclic-proto-expected.txt
>
>
> Index: LayoutTests/TestExpectations
> diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
> index
>
f176373d0c6d829d960541c868ffdb2b64254bb0..42c61136f52d938e71c87c34165f3e5dfdc5181a
> 100644
> --- a/LayoutTests/TestExpectations
> +++ b/LayoutTests/TestExpectations
> @@ -1182,9 +1182,6 @@ crbug.com/374936 [ Linux Win Debug ]
> svg/dynamic-updates/SVGImageElement-dom-pre
>  crbug.com/374936 [ Linux Win Debug ]
> svg/dynamic-updates/SVGImageElement-dom-height-attr.html [ ImageOnlyFailure
> Pass ]
>  crbug.com/374936 [ Linux Win Debug ]
> svg/dynamic-updates/SVGImageElement-dom-width-attr.html [ ImageOnlyFailure
> Pass ]
>
> -crbug.com/502427 fast/dom/Window/window-custom-prototype.html [ Pass
> Failure ]
> -crbug.com/502427 fast/js/cyclic-proto.html [ Pass Failure ]
> -
>  crbug.com/313438 svg/custom/relative-sized-use-on-symbol.xhtml [
> NeedsManualRebaseline ]
>  crbug.com/313438
> svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml [
> NeedsManualRebaseline ]
>
> Index: LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> diff --git
> a/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> b/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> index
>
636e8eb1e90a641de3ec042d19cd0b9d51daf903..1671e7f519349550cc566010b3fdde36d1efa625
> 100644
> --- a/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> +++ b/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> @@ -3,12 +3,12 @@ Test what happens when you set the window's prototype to
> various values.
>  On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".
>
>
> -FAIL __proto__ = window; __proto should throw Error: cyclic __proto__
> value. Threw exception Error: Cyclic __proto__ value.
> -FAIL __proto__ = chainPointingBackToWindow; __proto__ should throw Error:
> cyclic __proto__ value. Threw exception Error: Cyclic __proto__ value.
> +FAIL __proto__ = window; __proto should throw TypeError: cyclic __proto__
> value. Threw exception TypeError: cyclic __proto__ value.
> +FAIL __proto__ = chainPointingBackToWindow; __proto__ should throw
> TypeError: cyclic __proto__ value. Threw exception TypeError: cyclic
> __proto__ value.
>  PASS __proto__ = 1; __proto__ is originalWindowPrototype
>  PASS __proto__ = 'a string'; __proto__ is originalWindowPrototype
>  PASS __proto__ = anotherObject; __proto__ is anotherObject
> -FAIL anotherObject.__proto__ = window; __proto__ should throw Error:
> cyclic __proto__ value. Threw exception Error: Cyclic __proto__ value.
> +FAIL anotherObject.__proto__ = window; __proto__ should throw TypeError:
> cyclic __proto__ value. Threw exception TypeError: cyclic __proto__ value.
>  PASS __proto__ = 1; __proto__ is anotherObject
>  PASS __proto__ = 'a string'; __proto__ is anotherObject
>  PASS __proto__ = anotherObject; __proto__ is anotherObject
> Index: LayoutTests/fast/js/cyclic-proto-expected.txt
> diff --git a/LayoutTests/fast/js/cyclic-proto-expected.txt
> b/LayoutTests/fast/js/cyclic-proto-expected.txt
> index
>
7ca69bb55a95758835fe0ecb0d8bbb916ba05629..c2a268b128964b81602b025c5162f7c67392fdd5
> 100644
> --- a/LayoutTests/fast/js/cyclic-proto-expected.txt
> +++ b/LayoutTests/fast/js/cyclic-proto-expected.txt
> @@ -3,7 +3,7 @@ This test checks that setting a cyclic value for __proto__
> throws an exception a
>  On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".
>
>
> -PASS x.__proto__ = x; threw exception Error: Cyclic __proto__ value.
> +PASS x.__proto__ = x; threw exception TypeError: cyclic __proto__ value.
>  PASS x.__proto__ is originalProto
>  PASS successfullyParsed is true
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[caitp (gmail), 2015-06-21 08:17:26]

On 2015/06/21 04:15:33, arv wrote:
> In this case where the test is just wrong we should update the test too. We
> should only keep FAIL in the result when we expect/hope to fix our behavior
> in the future.
> On Jun 20, 2015 4:31 PM, <mailto:caitpotter88@gmail.com> wrote:
> 
> > Reviewers: arv,
> >
> > Message:
> > PTAL thanks
> >
> > Description:
> > Remove TestExpectations for crbug.com/502427 + fix tests
> >
> > BUG=502427, v8:4197
> > R=
> > LOG=N
> >
> > Please review this at https://codereview.chromium.org/1200523003/
> >
> > Base URL: https://chromium.googlesource.com/chromium/blink.git@master
> >
> > Affected files (+4, -7 lines):
> >   M LayoutTests/TestExpectations
> >   M LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> >   M LayoutTests/fast/js/cyclic-proto-expected.txt
> >
> >
> > Index: LayoutTests/TestExpectations
> > diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
> > index
> >
>
f176373d0c6d829d960541c868ffdb2b64254bb0..42c61136f52d938e71c87c34165f3e5dfdc5181a
> > 100644
> > --- a/LayoutTests/TestExpectations
> > +++ b/LayoutTests/TestExpectations
> > @@ -1182,9 +1182,6 @@ crbug.com/374936 [ Linux Win Debug ]
> > svg/dynamic-updates/SVGImageElement-dom-pre
> >  crbug.com/374936 [ Linux Win Debug ]
> > svg/dynamic-updates/SVGImageElement-dom-height-attr.html [ ImageOnlyFailure
> > Pass ]
> >  crbug.com/374936 [ Linux Win Debug ]
> > svg/dynamic-updates/SVGImageElement-dom-width-attr.html [ ImageOnlyFailure
> > Pass ]
> >
> > -crbug.com/502427 fast/dom/Window/window-custom-prototype.html [ Pass
> > Failure ]
> > -crbug.com/502427 fast/js/cyclic-proto.html [ Pass Failure ]
> > -
> >  crbug.com/313438 svg/custom/relative-sized-use-on-symbol.xhtml [
> > NeedsManualRebaseline ]
> >  crbug.com/313438
> > svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml [
> > NeedsManualRebaseline ]
> >
> > Index: LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> > diff --git
> > a/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> > b/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> > index
> >
>
636e8eb1e90a641de3ec042d19cd0b9d51daf903..1671e7f519349550cc566010b3fdde36d1efa625
> > 100644
> > --- a/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> > +++ b/LayoutTests/fast/dom/Window/window-custom-prototype-expected.txt
> > @@ -3,12 +3,12 @@ Test what happens when you set the window's prototype to
> > various values.
> >  On success, you will see a series of "PASS" messages, followed by "TEST
> > COMPLETE".
> >
> >
> > -FAIL __proto__ = window; __proto should throw Error: cyclic __proto__
> > value. Threw exception Error: Cyclic __proto__ value.
> > -FAIL __proto__ = chainPointingBackToWindow; __proto__ should throw Error:
> > cyclic __proto__ value. Threw exception Error: Cyclic __proto__ value.
> > +FAIL __proto__ = window; __proto should throw TypeError: cyclic __proto__
> > value. Threw exception TypeError: cyclic __proto__ value.
> > +FAIL __proto__ = chainPointingBackToWindow; __proto__ should throw
> > TypeError: cyclic __proto__ value. Threw exception TypeError: cyclic
> > __proto__ value.
> >  PASS __proto__ = 1; __proto__ is originalWindowPrototype
> >  PASS __proto__ = 'a string'; __proto__ is originalWindowPrototype
> >  PASS __proto__ = anotherObject; __proto__ is anotherObject
> > -FAIL anotherObject.__proto__ = window; __proto__ should throw Error:
> > cyclic __proto__ value. Threw exception Error: Cyclic __proto__ value.
> > +FAIL anotherObject.__proto__ = window; __proto__ should throw TypeError:
> > cyclic __proto__ value. Threw exception TypeError: cyclic __proto__ value.
> >  PASS __proto__ = 1; __proto__ is anotherObject
> >  PASS __proto__ = 'a string'; __proto__ is anotherObject
> >  PASS __proto__ = anotherObject; __proto__ is anotherObject
> > Index: LayoutTests/fast/js/cyclic-proto-expected.txt
> > diff --git a/LayoutTests/fast/js/cyclic-proto-expected.txt
> > b/LayoutTests/fast/js/cyclic-proto-expected.txt
> > index
> >
>
7ca69bb55a95758835fe0ecb0d8bbb916ba05629..c2a268b128964b81602b025c5162f7c67392fdd5
> > 100644
> > --- a/LayoutTests/fast/js/cyclic-proto-expected.txt
> > +++ b/LayoutTests/fast/js/cyclic-proto-expected.txt
> > @@ -3,7 +3,7 @@ This test checks that setting a cyclic value for __proto__
> > throws an exception a
> >  On success, you will see a series of "PASS" messages, followed by "TEST
> > COMPLETE".
> >
> >
> > -PASS x.__proto__ = x; threw exception Error: Cyclic __proto__ value.
> > +PASS x.__proto__ = x; threw exception TypeError: cyclic __proto__ value.
> >  PASS x.__proto__ is originalProto
> >  PASS successfullyParsed is true
> >
> >
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

if I get you, removing the FAILs should be okay because it should be doing the
right thing as-is, right?

> shouldThrow("__proto__ = window; __proto", "'TypeError: cyclic __proto__
value'"); << Shouldn't this be a ReferenceError before the [[SetPrototypeOf]]
ever happens?

The rest of these should all pass, right? I'll update the patch later, flight to
catch

[caitp (gmail), 2015-06-21 09:48:35]

made some changes that "seem" right.

Nightly has some issues with these, and I think most of the issues came from
trying to address security problems WRT accidentally recycling Object.prototype
across navigations --- I'm not sure if anything like that applies to chromium
atm.

[arv (Not doing code reviews), 2015-06-21 15:57:38]

LGTM

[arv (Not doing code reviews), 2015-06-21 15:57:42]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-06-21 15:57:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200523003/60001

[caitp (gmail), 2015-06-21 16:44:52]

On 2015/06/21 15:57:44, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1200523003/60001

Yeah I think the blink boys use lkgr so it won't pass there until lkgr is on v8
4.5.69 or higher

[commit-bot: I haz the power, 2015-06-21 17:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-21 17:09:51]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[caitp (gmail), 2015-06-23 02:42:37]

On 2015/06/21 17:09:51, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

It looks like LKGR is on v8 v4.5.70 now, so the tests should now pass

[caitp (gmail), 2015-06-23 02:54:41]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-23 02:54:41]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1200523003/#ps100001
(title: "Fix for real maybe?")

[commit-bot: I haz the power, 2015-06-23 02:54:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200523003/100001

[commit-bot: I haz the power, 2015-06-23 04:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 04:14:34]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60206)

[caitp (gmail), 2015-06-23 12:30:55]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-23 12:30:55]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1200523003/#ps120001
(title: "Fix for real?")

[commit-bot: I haz the power, 2015-06-23 12:31:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200523003/120001

[commit-bot: I haz the power, 2015-06-23 13:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 13:38:12]

Exceeded global retry quota

[caitp (gmail), 2015-06-23 13:45:34]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-23 13:45:34]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1200523003/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-06-23 13:46:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200523003/140001

[commit-bot: I haz the power, 2015-06-23 14:49:11]

Committed patchset #6 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197652