[Extensions] Kill off ExtensionMsg_AddMessageToConsole

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index f43d444c11a06309990368fec3b204e24ac6f74e..15ce68a9fb198106c4ed1318b30e29d17495d69e 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1010,7 +1010,7 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
     IPC_MESSAGE_HANDLER(InputMsg_ExecuteNoValueEditCommand,
                         OnExecuteNoValueEditCommand)
     IPC_MESSAGE_HANDLER(FrameMsg_CSSInsertRequest, OnCSSInsertRequest)
-    IPC_MESSAGE_HANDLER(FrameMsg_AddMessageToConsole, OnAddMessageToConsole)
+    IPC_MESSAGE_HANDLER(FrameMsg_AddMessageToConsole, AddMessageToConsole)

[nasko, 2015/06/23 10:53:13]

Let's leave OnAddMessageToConsole as the handler, which will just call the
AddMessageToConsole method. It keeps things consistent with IPC handlers and the
compiler should be smart enough to optimize it.
Additionally, we aren't making a private IPC handler a public method.

[Devlin, 2015/06/23 16:49:19]

Done.

     IPC_MESSAGE_HANDLER(FrameMsg_JavaScriptExecuteRequest,
                         OnJavaScriptExecuteRequest)
     IPC_MESSAGE_HANDLER(FrameMsg_JavaScriptExecuteRequestForTests,
@@ -1345,12 +1345,6 @@ void RenderFrameImpl::OnCSSInsertRequest(const std::string& css) {
   frame_->document().insertStyleSheet(WebString::fromUTF8(css));
 }
 
-void RenderFrameImpl::OnAddMessageToConsole(ConsoleMessageLevel level,
-                                            const std::string& message) {
-  if (devtools_agent_)
-    devtools_agent_->AddMessageToConsole(level, message);
-}
-
 void RenderFrameImpl::OnJavaScriptExecuteRequest(
     const base::string16& jscript,
     int id,
@@ -1891,6 +1885,12 @@ void RenderFrameImpl::EnsureMojoBuiltinsAreAvailable(
       ServiceRegistryJsWrapper::Create(isolate, &service_registry_).ToV8());
 }
 
+void RenderFrameImpl::AddMessageToConsole(ConsoleMessageLevel level,
+                                          const std::string& message) {
+  if (devtools_agent_)
+    devtools_agent_->AddMessageToConsole(level, message);
+}
+
 // blink::WebFrameClient implementation ----------------------------------------
 
 blink::WebPluginPlaceholder* RenderFrameImpl::createPluginPlaceholder(