Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: extensions/renderer/extension_frame_helper.cc

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/extension_frame_helper.cc
diff --git a/extensions/renderer/extension_frame_helper.cc b/extensions/renderer/extension_frame_helper.cc
index abb6f23e25d86e1d4cf5bcd98fc9378f1f04bfd9..8c9c7c24e25fc9801dd04415832140211f2dc62f 100644
--- a/extensions/renderer/extension_frame_helper.cc
+++ b/extensions/renderer/extension_frame_helper.cc
@@ -98,6 +98,16 @@ bool ExtensionFrameHelper::IsContextForEventPage(const ScriptContext* context) {
VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
}
+// static
+content::RenderFrame* ExtensionFrameHelper::RenderFrameForContext(
+ const ScriptContext* context) {
+ for (const ExtensionFrameHelper* helper : g_frame_helpers.Get()) {
+ if (context->GetRenderFrame() == helper->render_frame())
+ return helper->render_frame();
+ }
+ return nullptr;
+}
+
void ExtensionFrameHelper::DidCreateScriptContext(
v8::Local<v8::Context> context,
int extension_group,
@@ -116,8 +126,6 @@ void ExtensionFrameHelper::WillReleaseScriptContext(
bool ExtensionFrameHelper::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(ExtensionFrameHelper, message)
- IPC_MESSAGE_HANDLER(ExtensionMsg_AddMessageToConsole,
- OnAddMessageToConsole)
IPC_MESSAGE_HANDLER(ExtensionMsg_DispatchOnConnect,
OnExtensionDispatchOnConnect)
IPC_MESSAGE_HANDLER(ExtensionMsg_DeliverMessage, OnExtensionDeliverMessage)
@@ -136,12 +144,6 @@ bool ExtensionFrameHelper::OnMessageReceived(const IPC::Message& message) {
return handled;
}
-void ExtensionFrameHelper::OnAddMessageToConsole(
- content::ConsoleMessageLevel level,
- const std::string& message) {
- console::AddMessage(render_frame()->GetRenderView(), level, message);
-}
-
void ExtensionFrameHelper::OnExtensionDispatchOnConnect(
int target_port_id,
const std::string& channel_name,

Powered by Google App Engine
This is Rietveld 408576698