Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: extensions/renderer/console.h

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/console.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/console.h
diff --git a/extensions/renderer/console.h b/extensions/renderer/console.h
index f2b7f97d360d7eb6e2df72c9650ea6602f0f0c1c..79d338e773aa9122b8e457c12842c7d93fab5c76 100644
--- a/extensions/renderer/console.h
+++ b/extensions/renderer/console.h
@@ -11,37 +11,25 @@
#include "v8/include/v8.h"
namespace content {
-class RenderView;
+class RenderFrame;
}
namespace extensions {
-// Utility for logging messages to RenderViews.
+// Utility for logging messages to RenderFrames.
namespace console {
-// Adds |message| to the console of |render_view| at various log levels.
-void Debug(content::RenderView* render_view, const std::string& message);
-void Log(content::RenderView* render_view, const std::string& message);
-void Warn(content::RenderView* render_view, const std::string& message);
-void Error(content::RenderView* render_view, const std::string& message);
+// Adds |message| to the console of |render_frame|. If |render_frame| is null,
+// LOG()s the message instead.
+void Debug(content::RenderFrame* render_frame, const std::string& message);
+void Log(content::RenderFrame* render_frame, const std::string& message);
+void Warn(content::RenderFrame* render_frame, const std::string& message);
+void Error(content::RenderFrame* render_frame, const std::string& message);
// Logs an Error then crashes the current process.
-void Fatal(content::RenderView* render_view, const std::string& message);
+void Fatal(content::RenderFrame* render_frame, const std::string& message);
-void AddMessage(content::RenderView* render_view,
- content::ConsoleMessageLevel level,
- const std::string& message);
-
-// Adds |message| to the console that hosts |context|, if any.
-void Debug(v8::Local<v8::Context> context, const std::string& message);
-void Log(v8::Local<v8::Context> context, const std::string& message);
-void Warn(v8::Local<v8::Context> context, const std::string& message);
-void Error(v8::Local<v8::Context> context, const std::string& message);
-
-// Logs an Error then crashes the current process.
-void Fatal(v8::Local<v8::Context> context, const std::string& message);
-
-void AddMessage(v8::Local<v8::Context> context,
+void AddMessage(content::RenderFrame* render_frame,
content::ConsoleMessageLevel level,
const std::string& message);
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/console.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698