Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: chrome/renderer/extensions/app_bindings.cc

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/app_bindings.cc
diff --git a/chrome/renderer/extensions/app_bindings.cc b/chrome/renderer/extensions/app_bindings.cc
index af65cc997d230ebfeeaec917bc918d8925686975..7ead4ef766335a72157e65980d691b9f9b397c61 100644
--- a/chrome/renderer/extensions/app_bindings.cc
+++ b/chrome/renderer/extensions/app_bindings.cc
@@ -112,7 +112,9 @@ void AppBindings::GetDetailsForFrame(
WebLocalFrame* target_frame = WebLocalFrame::frameForContext(context);
if (!target_frame) {
- console::Error(args.GetIsolate()->GetCallingContext(),
+ ScriptContext* script_context = ScriptContextSet::GetContextByV8Context(
+ args.GetIsolate()->GetCallingContext());
+ console::Error(script_context ? script_context->GetRenderFrame() : nullptr,
"Could not find frame for specified object.");
return;
}

Powered by Google App Engine
This is Rietveld 408576698