[Extensions] Kill off ExtensionMsg_AddMessageToConsole

chrome/browser/extensions/api/mdns/mdns_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/mdns/mdns_api.h"
 
 #include <vector>
 
 #include "base/lazy_instance.h"
+#include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/common/extensions/api/mdns.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
-#include "extensions/common/extension_messages.h"
 
 namespace extensions {
 
 namespace mdns = api::mdns;
 
 namespace {
 
 // Whitelisted mDNS service types.
 const char kCastServiceType[] = "_googlecast._tcp.local";
 const char kPrivetServiceType[] = "_privet._tcp.local";
@@ skipping 177 matching lines @@
                                  &extension_ids,
                                  nullptr /* service_types */);
 
   std::string logged_message(std::string("[chrome.mdns] ") + message);
 
   // Log to the consoles of the background pages for those extensions.
   for (const std::string& extension_id : extension_ids) {
     extensions::ExtensionHost* host =
         extensions::ProcessManager::Get(browser_context_)
         ->GetBackgroundHostForExtension(extension_id);
-    if (!host)
-      continue;
-    content::RenderViewHost* rvh = host->render_view_host();
-    if (!rvh)
-      continue;
-    rvh->Send(new ExtensionMsg_AddMessageToConsole(
-        rvh->GetRoutingID(),
-        level,
-        logged_message));
+    content::RenderFrameHost* rfh =

[not at google - send to devlin, 2015/06/19 23:14:58]

This should probably use ProcessManager::GetRenderFrameHostsForExtension()
rather than just the background host (which obviously may not exist).

[Devlin, 2015/06/19 23:53:51]

That would be a change in behavior, and it would be kind of weird to log a
console message in a random render frame (or all render frames).  WDYT?

[not at google - send to devlin, 2015/06/22 17:54:10]

I think it's more weird to log it to the background page, since there might not
be a background page. Better would be to log straight to the error console
actually.

[Devlin, 2015/06/22 19:52:32]

Added a TODO.  I'd like to (try) to avoid behavior changes in this CL.

+        host ? host->host_contents()->GetMainFrame() : nullptr;
+    if (rfh)
+      rfh->AddMessageToConsole(level, logged_message);
   }
 }
 
 }  // namespace extensions