Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: ppapi/proxy/nacl_message_scanner.cc

Issue 1200473003: Revert of Make SharedMemoryHandle a class on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared_memory_make_class3_base
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/nacl_message_scanner.cc
diff --git a/ppapi/proxy/nacl_message_scanner.cc b/ppapi/proxy/nacl_message_scanner.cc
index 3e522f49b00a1cef190203a2a5a235d070be3a6b..a48ae8ea769271d68cdf0da21586d9afd6ead401 100644
--- a/ppapi/proxy/nacl_message_scanner.cc
+++ b/ppapi/proxy/nacl_message_scanner.cc
@@ -293,9 +293,6 @@
// message body, rather than passed in a separate FileDescriptorSet. Therefore,
// on Windows, any message containing handles must be rewritten in the POSIX
// format before we can send it to the NaCl plugin.
-// On Mac, base::SharedMemoryHandle has a different serialization than
-// base::FileDescriptor (which base::SharedMemoryHandle is typedef-ed to in
-// OS_NACL).
bool NaClMessageScanner::ScanMessage(
const IPC::Message& msg,
uint32_t type,
@@ -307,7 +304,7 @@
DCHECK(!new_msg_ptr->get());
bool rewrite_msg =
-#if defined(OS_WIN) || defined(OS_MACOSX)
+#if defined(OS_WIN)
true;
#else
false;
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698