Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1200463002: Add package:sky/mojo/asset_bundle.dart to wrap mojo:asset_bundle (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
viktorl
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add package:sky/mojo/asset_bundle.dart to wrap mojo:asset_bundle This Dart library exposes a more idiomatic interface to the asset_bundle service and provides integration with dart:sky. R=viktorl@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1aa34388caaa7e40a5fee8bfdcdce9034f6fde0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/sdk/lib/mojo/asset_bundle.dart View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-19 17:12:39 UTC) #1
viktorl
lgtm
5 years, 6 months ago (2015-06-19 17:38:09 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-19 18:01:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1aa34388caaa7e40a5fee8bfdcdce9034f6fde0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698