Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(142)

Issue 1200423004: Remaining Node to Element conversion in FocusController (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remaining Node to Element conversion in FocusController - Converted Node*/Node& parameter to Element where possible - Converted NodeTraversal to ElementTraversal where possible There are still some places where Node/NodeTraversal are used, but converting them to use Element made the code less readable. This is the last of Node to Element conversion for FocusController. BUG=499667 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M Source/core/page/FocusController.cpp View 8 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200423004/1
4 years, 10 months ago (2015-06-24 10:29:41 UTC) #2
kochi
PTAL
4 years, 10 months ago (2015-06-24 11:10:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-24 11:28:05 UTC) #6
hayato
lgtm
4 years, 10 months ago (2015-06-25 00:55:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200423004/1
4 years, 10 months ago (2015-06-25 01:00:13 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 01:04:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197788

Powered by Google App Engine
This is Rietveld 408576698