Oilpan: make XHR progress event throttling finalization safe.

Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h

 /*
  * Copyright (C) 2010 Julien Chaffraix <jchaffraix@webkit.org>
  * All right reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 31 matching lines @@
 //   "dispatch a progress event named progress about every 50ms or for every
 //   byte received, whichever is least frequent".
 //
 // readystatechange events also go through this class since ProgressEvents and
 // readystatechange events affect each other.
 //
 // In the comments for this class:
 // - "progress" event means an event named "progress"
 // - ProgressEvent means an event using the ProgressEvent interface defined in
 //   the spec.
-class XMLHttpRequestProgressEventThrottle final : public TimerBase {
-    DISALLOW_ALLOCATION();
+class XMLHttpRequestProgressEventThrottle final : public NoBaseWillBeGarbageCollectedFinalized<XMLHttpRequestProgressEventThrottle>, public TimerBase {
 public:
+    static PassOwnPtrWillBeRawPtr<XMLHttpRequestProgressEventThrottle> create(EventTarget* eventTarget)
+    {
+        return adoptPtrWillBeNoop(new XMLHttpRequestProgressEventThrottle(eventTarget));
+    }
+    virtual ~XMLHttpRequestProgressEventThrottle();
+
     enum DeferredEventAction {
         Ignore,
         Clear,
         Flush,
     };
 
-    explicit XMLHttpRequestProgressEventThrottle(EventTarget*);
-    virtual ~XMLHttpRequestProgressEventThrottle();
-
     // Dispatches a ProgressEvent.
     //
     // Special treatment for events named "progress" is implemented to dispatch
     // them at the required frequency. If this object is suspended, the given
     // ProgressEvent overwrites the existing. I.e. only the latest one gets
     // queued. If the timer is running, this method just updates
     // m_lengthComputable, m_loaded and m_total. They'll be used on next
     // fired() call.
     void dispatchProgressEvent(const AtomicString&, bool lengthComputable, unsigned long long loaded, unsigned long long total);
     // Dispatches the given event after operation about the "progress" event
     // depending on the value of the ProgressEventAction argument.
     void dispatchReadyStateChangeEvent(PassRefPtrWillBeRawPtr<Event>, DeferredEventAction);
 
     void suspend();
     void resume();
 
+    // Need to promptly stop this timer when it is deemed finalizable.
+    EAGERLY_FINALIZE();
     DECLARE_TRACE();
 
 private:
+    explicit XMLHttpRequestProgressEventThrottle(EventTarget*);
+
     // The main purpose of this class is to throttle the "progress"
     // ProgressEvent dispatching. This class represents such a deferred
     // "progress" ProgressEvent.
     class DeferredEvent;
     static const double minimumProgressEventDispatchingIntervalInSeconds;
 
     virtual void fired() override;
     void dispatchDeferredEvent();
 
     // Non-Oilpan, keep a weak pointer to our XMLHttpRequest object as it is
     // the one holding us. With Oilpan, a simple strong Member can be used -
     // this XMLHttpRequestProgressEventThrottle (part) object dies together
     // with the XMLHttpRequest object.
     RawPtrWillBeMember<EventTarget> m_target;
 
     // A slot for the deferred "progress" ProgressEvent. When multiple events
     // arrive, only the last one is stored and others are discarded.
     const OwnPtr<DeferredEvent> m_deferred;
 };
 
 } // namespace blink
 
 #endif // XMLHttpRequestProgressEventThrottle_h