Issue 12004: Remove dependencies on base/ from MIMETypeRegistry.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12004: Remove dependencies on base/ from MIMETypeRegistry.cpp (Closed)

Created:
12 years ago by please use my chromium address

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remove dependencies on base/ from MIMETypeRegistry.cpp

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
M	webkit/glue/chromium_bridge_impl.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	webkit/port/platform/MIMETypeRegistry.cpp	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/port/platform/chromium/ChromiumBridge.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

12 years ago (2008-11-26 19:49:10 UTC) #1

LGTM

There's actually a bit more work to be done here since MIMETypeRegistry.cpp is
actually a fork of third_party/WebKit/WebCore/platform/MIMETypeRegistry.cpp

We need to send some kind of patch upstream to make it possible for us to
override these methods within PLATFORM(CHROMIUM).

That can definitely happen after this CL is landed.

Expand Messages | Collapse Messages