components/url_fixer/url_fixer_unittest.cc - Issue 1200393002: Add more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_fixer/url_fixer_unittest.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string

Patch Set: Android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/url_fixer/url_fixer_unittest.cc

diff --git a/components/url_fixer/url_fixer_unittest.cc b/components/url_fixer/url_fixer_unittest.cc

index c2b3e263480646d5bfd667b3c315aa355822e800..ee192892783afd99a9c4f6f456178a9c18b844e6 100644

--- a/components/url_fixer/url_fixer_unittest.cc

+++ b/components/url_fixer/url_fixer_unittest.cc

@@ -507,7 +507,7 @@ TEST(URLFixerTest, FixupRelativeFile) {

// test file in the subdir with different slashes and escaping.

base::FilePath::StringType relative_file_str = sub_dir.value() +

FILE_PATH_LITERAL("/") + sub_file.value();

- ReplaceSubstringsAfterOffset(&relative_file_str, 0,

+ base::ReplaceSubstringsAfterOffset(&relative_file_str, 0,

FILE_PATH_LITERAL(" "), FILE_PATH_LITERAL("%20"));

EXPECT_TRUE(IsMatchingFileURL(

url_fixer::FixupRelativeFile(temp_dir_.path(),