Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: chrome/browser/jumplist_win.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string
Patch Set: Android Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/jumplist_win.cc
diff --git a/chrome/browser/jumplist_win.cc b/chrome/browser/jumplist_win.cc
index bed6653d6f79b919a736f456698aa8133528ba42..5bd8ddcc12cc30c7885d7242a3a047765dc6557d 100644
--- a/chrome/browser/jumplist_win.cc
+++ b/chrome/browser/jumplist_win.cc
@@ -108,7 +108,8 @@ bool UpdateTaskCategory(
if (incognito_availability != IncognitoModePrefs::FORCED) {
scoped_refptr<ShellLinkItem> chrome = CreateShellLink();
base::string16 chrome_title = l10n_util::GetStringUTF16(IDS_NEW_WINDOW);
- ReplaceSubstringsAfterOffset(&chrome_title, 0, L"&", L"");
+ base::ReplaceSubstringsAfterOffset(
+ &chrome_title, 0, L"&", base::StringPiece16());
chrome->set_title(chrome_title);
chrome->set_icon(chrome_path.value(), 0);
items.push_back(chrome);
@@ -122,7 +123,8 @@ bool UpdateTaskCategory(
incognito->GetCommandLine()->AppendSwitch(switches::kIncognito);
base::string16 incognito_title =
l10n_util::GetStringUTF16(IDS_NEW_INCOGNITO_WINDOW);
- ReplaceSubstringsAfterOffset(&incognito_title, 0, L"&", L"");
+ base::ReplaceSubstringsAfterOffset(
+ &incognito_title, 0, L"&", base::StringPiece16());
incognito->set_title(incognito_title);
incognito->set_icon(chrome_path.value(), 0);
items.push_back(incognito);
« no previous file with comments | « chrome/browser/extensions/menu_manager.cc ('k') | chrome/browser/local_discovery/privetv3_session_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698