Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: chrome/browser/chromeos/login/login_browsertest.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string
Patch Set: Android Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/login_browsertest.cc
diff --git a/chrome/browser/chromeos/login/login_browsertest.cc b/chrome/browser/chromeos/login/login_browsertest.cc
index 6f707f3514ba9dbb62313593ca1499012bef0e31..5bc2a6ef161ad6fe4604bd9f1fd80d1b2289c5d7 100644
--- a/chrome/browser/chromeos/login/login_browsertest.cc
+++ b/chrome/browser/chromeos/login/login_browsertest.cc
@@ -144,8 +144,8 @@ class LoginTest : public chromeos::LoginManagerTest {
"document.getElementsByName('password')[0].value = '$Password';"
"document.getElementById('submit-button').click();"
"})();";
- ReplaceSubstringsAfterOffset(&js, 0, "$Email", user_email);
- ReplaceSubstringsAfterOffset(&js, 0, "$Password", password);
+ base::ReplaceSubstringsAfterOffset(&js, 0, "$Email", user_email);
+ base::ReplaceSubstringsAfterOffset(&js, 0, "$Password", password);
ExecuteJsInGaiaAuthFrame(js);
}
@@ -178,7 +178,7 @@ class LoginTest : public chromeos::LoginManagerTest {
"})";
ASSERT_TRUE(content::ExecuteScript(web_contents(), js));
std::string set_email = email_input + ".value = '$Email'";
- ReplaceSubstringsAfterOffset(&set_email, 0, "$Email", user_email);
+ base::ReplaceSubstringsAfterOffset(&set_email, 0, "$Email", user_email);
ASSERT_TRUE(content::ExecuteScript(web_contents(), set_email));
ASSERT_TRUE(content::ExecuteScript(web_contents(),
email_next_button + ".fire('tap')"));
@@ -188,7 +188,7 @@ class LoginTest : public chromeos::LoginManagerTest {
} while (message != "\"switchToPassword\"");
std::string set_password = password_input + ".value = '$Password'";
- ReplaceSubstringsAfterOffset(&set_password, 0, "$Password", password);
+ base::ReplaceSubstringsAfterOffset(&set_password, 0, "$Password", password);
ASSERT_TRUE(content::ExecuteScript(web_contents(), set_password));
ASSERT_TRUE(content::ExecuteScript(web_contents(),
password_next_button + ".fire('tap')"));
« no previous file with comments | « chrome/browser/chromeos/app_mode/fake_cws.cc ('k') | chrome/browser/chromeos/login/saml/saml_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698