Issue 1200383004: Revert "Cleanup travis passes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1200383004: Revert "Cleanup travis passes" (Closed)

Created:
5 years, 6 months ago by vsm

Modified:
5 years, 6 months ago

Reviewers:
Jennifer Messerly, kevmoo

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Cleanup travis passes" Looks like this change broke the presubmit pass - reverting just this for now. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/4a81219d4251f92305c65131f4894efd426a05e3

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	.travis.yml	View		1 chunk	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as 4a81219d4251f92305c65131f4894efd426a05e3 (presubmit successful).

5 years, 6 months ago (2015-06-24 17:34:59 UTC) #1

vsm

https://codereview.chromium.org/1200383004/diff/1/.travis.yml File .travis.yml (right): https://codereview.chromium.org/1200383004/diff/1/.travis.yml#newcode16 .travis.yml:16: - npm install This did get us back to ...

5 years, 6 months ago (2015-06-24 17:43:17 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages