Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1200373003: JSON.stringify should handle the replacer before the space (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

JSON.stringify should handle the replacer before the space BUG=v8:4227 LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/206cd93b5a8bdef7da2e5f3c119c338f87f61789 Cr-Commit-Position: refs/heads/master@{#29273}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -21 lines) Patch
M src/json.js View 1 2 chunks +21 lines, -21 lines 0 comments Download
A test/mjsunit/json-replacer-order.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-24 21:30:04 UTC) #2
arv (Not doing code reviews)
rebase
5 years, 6 months ago (2015-06-24 23:11:01 UTC) #3
arv (Not doing code reviews)
PTAL Feel free to cq if it looks good to you
5 years, 6 months ago (2015-06-24 23:11:59 UTC) #4
adamk
lgtm
5 years, 6 months ago (2015-06-24 23:21:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200373003/40001
5 years, 6 months ago (2015-06-24 23:21:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-25 00:04:31 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 00:04:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/206cd93b5a8bdef7da2e5f3c119c338f87f61789
Cr-Commit-Position: refs/heads/master@{#29273}

Powered by Google App Engine
This is Rietveld 408576698