Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1200343002: gold: ByBlame WIP (Closed)

Created:
5 years, 6 months ago by jcgregorio
Modified:
5 years, 5 months ago
Reviewers:
stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

gold: Add a page to display blamelist groups, and a second page for triaging untriaged digests in one blamelist group. Screenshot: https://screenshot.googleplex.com/hWKvAzcXWe8.png Landing as TBR for now since I want to get some feedback on this feature from a few people. Once we're happy I can add links to the /byblame page from the menu. BUG=skia: TBR=stephana Committed: https://skia.googlesource.com/buildbot/+/d866229db37a7f8e48f058cc2e15a597f880ae58

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : kinda working #

Patch Set 4 : working, making prettier #

Patch Set 5 : prettier #

Patch Set 6 : linkify #

Patch Set 7 : pretty enough #

Patch Set 8 : clean #

Patch Set 9 : comments #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -46 lines) Patch
M golden/elements.html View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M golden/go/skiacorrectness/main.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M golden/go/skiacorrectness/main2.go View 1 2 3 4 5 6 7 8 6 chunks +226 lines, -9 lines 0 comments Download
A golden/res/imp/commit-panel.html View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
M golden/res/imp/testsummarydetails.html View 1 2 3 4 3 chunks +48 lines, -33 lines 0 comments Download
A golden/templates/blamelist.html View 1 2 3 4 5 6 7 1 chunk +77 lines, -0 lines 0 comments Download
A golden/templates/byblame.html View 1 2 3 4 5 6 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200343002/170001
5 years, 5 months ago (2015-06-24 20:23:25 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-24 20:24:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #10 (id:170001) as
https://skia.googlesource.com/buildbot/+/d866229db37a7f8e48f058cc2e15a597f880...

Powered by Google App Engine
This is Rietveld 408576698