Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1200323005: remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove SK_SUPPORT_LEGACY_PATHOP_ENUMS BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/8bcc7a00febd737f7e82513bd5e4a697526626de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M include/pathops/SkPathOps.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200323005/1
5 years, 6 months ago (2015-06-24 04:59:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200323005/1
5 years, 6 months ago (2015-06-24 05:00:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8bcc7a00febd737f7e82513bd5e4a697526626de
5 years, 6 months ago (2015-06-24 05:05:22 UTC) #6
scroggo
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1203983003/ by scroggo@google.com. ...
5 years, 6 months ago (2015-06-24 15:05:32 UTC) #7
tomhudson
5 years, 6 months ago (2015-06-24 18:00:27 UTC) #8
Message was sent while issue was closed.
A change has landed in the master branch of the Android framework to unbreak the
build; this should be safe to reland.
Extra credit for fixing up the strings in the debugger.

Powered by Google App Engine
This is Rietveld 408576698