Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 1200283002: Remove unneeded expectation for root-renderer-with-opacity-filter.html (Closed)

Created:
4 years, 10 months ago by Stephen Chennney
Modified:
4 years, 10 months ago
Reviewers:
Xianzhu, wangxianzhu
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unneeded expectation for root-renderer-with-opacity-filter.html And update other bug number as requested in crbug.com/458601 R=wangxianzhu BUG=458601, 485428 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197748

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moving expectation and updating bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/SlowTests View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Stephen Chennney
Flakiness indicates that this is the right thing to do. Let's see if the bots ...
4 years, 10 months ago (2015-06-23 19:29:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200283002/1
4 years, 10 months ago (2015-06-23 19:29:39 UTC) #3
Xianzhu
https://codereview.chromium.org/1200283002/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1200283002/diff/1/LayoutTests/TestExpectations#newcode1285 LayoutTests/TestExpectations:1285: crbug.com/458428 css3/filters/huge-region.html [ Timeout ] Is the new bug ...
4 years, 10 months ago (2015-06-23 19:46:27 UTC) #5
Stephen Chennney
You're right - that bug number is not right. I'll have to find the right ...
4 years, 10 months ago (2015-06-23 20:09:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200283002/20001
4 years, 10 months ago (2015-06-23 20:17:08 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60404)
4 years, 10 months ago (2015-06-23 21:53:25 UTC) #10
Stephen Chennney
Bump.
4 years, 10 months ago (2015-06-24 14:30:14 UTC) #11
Xianzhu
lgtm
4 years, 10 months ago (2015-06-24 15:39:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200283002/20001
4 years, 10 months ago (2015-06-24 15:39:50 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 15:44:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197748

Powered by Google App Engine
This is Rietveld 408576698