LayoutTests/fast/backgrounds/root-background-display-none-no-crash-expected.txt - Issue 1200263004: Should not crash when background image a display:none presents on the root

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/backgrounds/root-background-display-none-no-crash-expected.txt

Issue 1200263004: Should not crash when background image a display:none presents on the root (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1

	2 html {
	pdr. 2015/06/24 02:31:40 This doesn't seem quite right. Did you mean for th This doesn't seem quite right. Did you mean for this to be an -expected.html file? Or, can you just document.write('PASS') instead of dumpAsText. It looks like new technology is being built for these crash expectations, but isn't quite ready yet. https://groups.google.com/a/chromium.org/d/msg/blink-dev/MszepzweRq4/VtqGLPCK... has more info. trchen 2015/06/24 22:05:52 Looks like dumpAsText is doing funny things when t Show quoted text On 2015/06/24 02:31:40, pdr wrote: > This doesn't seem quite right. Did you mean for this to be an -expected.html > file? Or, can you just document.write('PASS') instead of dumpAsText. > > It looks like new technology is being built for these crash expectations, but > isn't quite ready yet. > https://groups.google.com/a/chromium.org/d/msg/blink-dev/MszepzweRq4/VtqGLPCK... > has more info. Looks like dumpAsText is doing funny things when the root element has display:none. document.write('PASS') solved the issue. We still want dumpAsText() though, otherwise it wastes time dumping a white png.
	3 display: none;

	4 background-image: linear-gradient(black, black);

	5 }

	6

	7

	8

	9 runAfterLayoutAndPaint(function(){

	10 if (window.testRunner)

	11 testRunner.dumpAsText();

	12 }, true);

	13

	14 This test should not crash due to referencing a null root element renderer when painting root background.

	15

OLD	NEW

« no previous file with comments | « LayoutTests/fast/backgrounds/root-background-display-none-no-crash.html ('k') | Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »