Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 1200233005: Support delta-compressed variations server responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing missing return in !is_compressed case. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.h
diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h
index 71a89864a8ca9baadacce79e4b6238f017026f0e..f96f31e45a9e9a0b4fa512d100c477a478f6762f 100644
--- a/chrome/browser/metrics/variations/variations_service.h
+++ b/chrome/browser/metrics/variations/variations_service.h
@@ -152,9 +152,11 @@ class VariationsService
// Stores the seed to prefs. Set as virtual and protected so that it can be
// overridden by tests.
- virtual void StoreSeed(const std::string& seed_data,
+ virtual bool StoreSeed(const std::string& seed_data,
const std::string& seed_signature,
- const base::Time& date_fetched);
+ const std::string& country_code,
+ const base::Time& date_fetched,
+ bool is_delta_compressed);
// Creates the VariationsService with the given |local_state| prefs service
// and |state_manager|. This instance will take ownership of |notifier|.
@@ -172,6 +174,7 @@ class VariationsService
FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, SeedDateUpdatedOn304Status);
FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest,
LoadPermanentConsistencyCountry);
+ FRIEND_TEST_ALL_PREFIXES(VariationsServiceTest, CountryHeader);
// Set of different possible values to report for the
// Variations.LoadPermanentConsistencyCountryResult histogram. This enum must
@@ -258,6 +261,11 @@ class VariationsService
// Tracks whether the initial request to the variations server had completed.
bool initial_request_completed_;
+ // Indicates that the next request to the variations service shouldn't specify
+ // that it supports delta compression. Set to true when a delta compressed
+ // response encountered an error.
+ bool disable_deltas_for_next_request_;
+
// Helper class used to tell this service if it's allowed to make network
// resource requests.
scoped_ptr<web_resource::ResourceRequestAllowedNotifier>

Powered by Google App Engine
This is Rietveld 408576698