Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: lib/runtime/dart/async.js

Issue 1200233004: fixes #168, dart:js implementation with a test (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix error (window not defined) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_js_helper.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/async.js
diff --git a/lib/runtime/dart/async.js b/lib/runtime/dart/async.js
index 036b9f222b05a8b6fe261f783013c781be738f0d..a3eb6063833449f6ad0d58228b5c152cf7e847ee 100644
--- a/lib/runtime/dart/async.js
+++ b/lib/runtime/dart/async.js
@@ -4,9 +4,8 @@ dart_library.library('dart/async', null, /* Imports */[
'dart/_internal',
'dart/collection'
], /* Lazy imports */[
- 'dart/_isolate_helper',
- 'dart/_js_helper'
-], function(exports, dart, core, _internal, collection, _isolate_helper, _js_helper) {
+ 'dart/_isolate_helper'
+], function(exports, dart, core, _internal, collection, _isolate_helper) {
'use strict';
let dartx = dart.dartx;
function _invokeErrorHandler(errorHandler, error, stackTrace) {
@@ -2788,7 +2787,7 @@ dart_library.library('dart/async', null, /* Imports */[
};
dart.fn(internalCallback);
;
- let observer = new self.MutationObserver(_js_helper.convertDartClosureToJS(internalCallback, 1));
+ let observer = new self.MutationObserver(internalCallback);
observer.observe(div, {childList: true});
return dart.fn(callback => {
dart.assert(storedCallback == null);
@@ -2809,7 +2808,7 @@ dart_library.library('dart/async', null, /* Imports */[
dart.fn(internalCallback);
;
_isolate_helper.enterJsAsync();
- self.scheduleImmediate(_js_helper.convertDartClosureToJS(internalCallback, 0));
+ self.scheduleImmediate(internalCallback);
}
static _scheduleImmediateWithSetImmediate(callback) {
let internalCallback = () => {
@@ -2819,7 +2818,7 @@ dart_library.library('dart/async', null, /* Imports */[
dart.fn(internalCallback);
;
_isolate_helper.enterJsAsync();
- self.setImmediate(_js_helper.convertDartClosureToJS(internalCallback, 0));
+ self.setImmediate(internalCallback);
}
static _scheduleImmediateWithTimer(callback) {
Timer._createTimer(core.Duration.ZERO, callback);
« no previous file with comments | « lib/runtime/dart/_js_helper.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698