sky/engine/core/rendering/RenderBox.h - Issue 1200233002: Use the baseline information exposed by C++ to pipe baseline data through RenderBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBox.h

Issue 1200233002: Use the baseline information exposed by C++ to pipe baseline data through RenderBox. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/RenderBox.h

diff --git a/sky/engine/core/rendering/RenderBox.h b/sky/engine/core/rendering/RenderBox.h

index 2304e9b79ef326f52692f3ae5ba6a38e106e2d5b..6caac8ee490a5df8e20ef7da027e2797b02d2802 100644

--- a/sky/engine/core/rendering/RenderBox.h

+++ b/sky/engine/core/rendering/RenderBox.h

@@ -429,7 +429,8 @@ public:

RenderLayer* enclosingFloatPaintingLayer() const;

- virtual int firstLineBoxBaseline() const { return -1; }

+ // if autoBaseline is true, baselineType is ignored and determined from the context

eseidel 2015/06/24 23:20:35 Why not just make it a separate method? firstLine

+ virtual int firstLineBoxBaseline(bool autoBaseline = true, FontBaseline baselineType = AlphabeticBaseline) const { return -1; }

virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // Returns -1 if we should skip this box when computing the baseline of an inline-block.

bool isFlexItem() const { return !isInline() && !isFloatingOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBox(); }

« sky/engine/core/rendering/RenderBlock.h ('K') | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderFlexibleBox.h » ('j') | no next file with comments »