Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 1200233002: Use the baseline information exposed by C++ to pipe baseline data through RenderBox. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/Element.cpp
diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp
index 367843c5dd2b0fae2e187ba0c2067786f09e2888..498dcf8b5755b7f7697c5498723bece8cbc1fdaa 100644
--- a/sky/engine/core/dom/Element.cpp
+++ b/sky/engine/core/dom/Element.cpp
@@ -975,14 +975,14 @@ void Element::setMaxContentWidth(double width)
double Element::alphabeticBaseline() const
{
if (RenderBox* box = renderBox())
- return box->baselinePosition(AlphabeticBaseline, true, HorizontalLine, PositionOfInteriorLineBoxes);
+ return box->firstLineBoxBaseline(false, AlphabeticBaseline);
eseidel 2015/06/24 23:20:35 Please use an enum instead of a bool in non-setter
return 0;
}
double Element::ideographicBaseline() const
{
if (RenderBox* box = renderBox())
- return box->baselinePosition(IdeographicBaseline, true, HorizontalLine, PositionOfInteriorLineBoxes);
+ return box->firstLineBoxBaseline(false, IdeographicBaseline);
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698