sky/engine/core/rendering/RenderParagraph.h - Issue 1200233002: Use the baseline information exposed by C++ to pipe baseline data through RenderBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderParagraph.h

Issue 1200233002: Use the baseline information exposed by C++ to pipe baseline data through RenderBox. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/rendering/RenderParagraph.h

diff --git a/sky/engine/core/rendering/RenderParagraph.h b/sky/engine/core/rendering/RenderParagraph.h

index d7015634ba4d1e62aa4b6911061a9cad57e2d0c1..3d942c7319927bac2dd2e295b170731d2cb4dde5 100644

--- a/sky/engine/core/rendering/RenderParagraph.h

+++ b/sky/engine/core/rendering/RenderParagraph.h

@@ -74,7 +74,7 @@ protected:

void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const final;

- int firstLineBoxBaseline() const final;

+ int firstLineBoxBaseline(FontBaselineOrAuto baselineType) const final;

int lastLineBoxBaseline(LineDirectionMode) const final;

private:

« no previous file with comments | « sky/engine/core/rendering/RenderFlexibleBox.cpp ('k') | sky/engine/core/rendering/RenderParagraph.cpp » ('j') | no next file with comments »