Issue 1200193003: Revert of SkPDF: Annotations are clipped by canvas clip stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1200193003: Revert of SkPDF: Annotations are clipped by canvas clip stack. (Closed)

Created:
5 years, 6 months ago by hal.canary

Modified:
5 years, 6 months ago

Reviewers:
tomhudson, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of SkPDF: Annotations are clipped by canvas clip stack. (patchset #2 id:20001 of https://codereview.chromium.org/1148263005/) Reason for revert: http://crbug.com/503541 Original issue's description: > SkPDF: Annotations are clipped by canvas clip stack. > > Also, remove some SkPDFDevice functions. > > Will fix this GM: http://crrev.com/1159273003 > > BUG=skia:3872 > > Committed: https://skia.googlesource.com/skia/+/eee0e4e9d343d8b6c5ae2da7f17196f00d8859bc TBR=tomhudson@google.com,reed@google.com BUG=skia:3872 BUG=503541 Committed: https://skia.googlesource.com/skia/+/1c75515a7cbfb46e1af14366ada4e01f6a9e6a7a

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -115 lines)			Patch
	M	src/pdf/SkPDFDevice.h	View		1 chunk	+9 lines, -1 line	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		6 chunks	+107 lines, -114 lines	0 comments	Download

Total messages: 5 (2 generated)

hal.canary

Created Revert of SkPDF: Annotations are clipped by canvas clip stack.

5 years, 6 months ago (2015-06-23 17:52:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200193003/1

5 years, 6 months ago (2015-06-23 17:53:35 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-23 17:59:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c75515a7cbfb46e1af14366ada4e01f6a9e6a7a