Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1200123004: [arm64][turbofan] Fix implementation of Float64Min. (Closed)

Created:
5 years, 6 months ago by jbramley
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64][turbofan] Fix implementation of Float64Min. ARM64's `fmin` and `fmax` instructions don't have the same behaviour as TurboFan's Float(32|64)(Min|Max) functions. BUG=4206 LOG=N Committed: https://crrev.com/d783b763629526a1ec57a9f14caa61d0166efac7 Cr-Commit-Position: refs/heads/master@{#29229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-4206.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbramley
The bug (4206) affects MIPS r6 too, but I don't know the proper fix; MIPS ...
5 years, 6 months ago (2015-06-23 11:32:06 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-23 11:33:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200123004/1
5 years, 6 months ago (2015-06-23 11:33:14 UTC) #5
commit-bot: I haz the power
The author jacob.bramley@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-23 11:33:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 11:58:54 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 11:59:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d783b763629526a1ec57a9f14caa61d0166efac7
Cr-Commit-Position: refs/heads/master@{#29229}

Powered by Google App Engine
This is Rietveld 408576698