Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: cc/scheduler/begin_frame_source.h

Issue 1200113003: cc: Cleanup DelayBasedTimeSource code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@task_runner_refptr
Patch Set: Fix race between missed tick and normal tick Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source.cc » ('j') | cc/scheduler/begin_frame_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_source.h
diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h
index 9eb3ea279daf7c6d04b656d06c25b87d65a94b50..ff3452a4f1f542d96da348b9e7abf741ba59aa35 100644
--- a/cc/scheduler/begin_frame_source.h
+++ b/cc/scheduler/begin_frame_source.h
@@ -207,7 +207,7 @@ class CC_EXPORT BackToBackBeginFrameSource : public BeginFrameSourceBase {
// A frame source which is locked to an external parameters provides from a
// vsync source and generates BeginFrameArgs for it.
class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase,
- public TimeSourceClient {
+ public DelayBasedTimeSourceClient {
public:
static scoped_ptr<SyntheticBeginFrameSource> Create(
base::SingleThreadTaskRunner* task_runner,
@@ -220,11 +220,13 @@ class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase,
// Tracing
void AsValueInto(base::trace_event::TracedValue* dict) const override;
- // TimeSourceClient
+ // DelayBasedTimeSourceClient
+ void OnMissedTick() override;
void OnTimerTick() override;
protected:
explicit SyntheticBeginFrameSource(
+ base::SingleThreadTaskRunner* task_runner,
scoped_ptr<DelayBasedTimeSource> time_source);
BeginFrameArgs CreateBeginFrameArgs(base::TimeTicks frame_time,
@@ -233,9 +235,12 @@ class CC_EXPORT SyntheticBeginFrameSource : public BeginFrameSourceBase,
// BeginFrameSourceBase
void OnNeedsBeginFramesChange(bool needs_begin_frames) override;
+ base::SingleThreadTaskRunner* task_runner_;
scoped_ptr<DelayBasedTimeSource> time_source_;
private:
+ base::WeakPtrFactory<SyntheticBeginFrameSource> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(SyntheticBeginFrameSource);
};
« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source.cc » ('j') | cc/scheduler/begin_frame_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698