Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3407)

Unified Diff: cc/scheduler/begin_frame_source.cc

Issue 1200113003: cc: Cleanup DelayBasedTimeSource code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@task_runner_refptr
Patch Set: mithro's review Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source.h ('k') | cc/scheduler/delay_based_time_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_source.cc
diff --git a/cc/scheduler/begin_frame_source.cc b/cc/scheduler/begin_frame_source.cc
index bc828026303bce098331606e8c675a73bf5ff110..d9cadc83e726f7ceaca6fb32298c279b18c1ccb5 100644
--- a/cc/scheduler/begin_frame_source.cc
+++ b/cc/scheduler/begin_frame_source.cc
@@ -221,8 +221,7 @@ SyntheticBeginFrameSource::SyntheticBeginFrameSource(
}
SyntheticBeginFrameSource::~SyntheticBeginFrameSource() {
- if (NeedsBeginFrames())
- time_source_->SetActive(false);
+ time_source_->SetActive(false);
}
void SyntheticBeginFrameSource::OnUpdateVSyncParameters(
@@ -239,7 +238,7 @@ BeginFrameArgs SyntheticBeginFrameSource::CreateBeginFrameArgs(
time_source_->Interval(), type);
}
-// TimeSourceClient support
+// DelayBasedTimeSourceClient support
void SyntheticBeginFrameSource::OnTimerTick() {
CallOnBeginFrame(CreateBeginFrameArgs(time_source_->LastTickTime(),
BeginFrameArgs::NORMAL));
@@ -251,6 +250,7 @@ void SyntheticBeginFrameSource::OnNeedsBeginFramesChange(
base::TimeTicks missed_tick_time =
time_source_->SetActive(needs_begin_frames);
if (!missed_tick_time.is_null()) {
+ DCHECK(needs_begin_frames);
CallOnBeginFrame(
CreateBeginFrameArgs(missed_tick_time, BeginFrameArgs::MISSED));
}
« no previous file with comments | « cc/scheduler/begin_frame_source.h ('k') | cc/scheduler/delay_based_time_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698