Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1200103008: Rename SkFontConfigParser_android SkFontMgr_android_parser. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
mtklein, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkFontConfigParser_android SkFontMgr_android_parser. There are a number of files with 'FontConfig' in their names which just have to do with font configuration, but nothing to do with the FontConfig project or even with each other. This clarifies that these files deal with parsing for the Android font manager. Committed: https://skia.googlesource.com/skia/+/c53085413e0b4704aa89cc18396613d59e6ccb4d

Patch Set 1 #

Patch Set 2 : Update test name and exclusion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1251 lines) Patch
M gyp/ports.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
D src/ports/SkFontConfigParser_android.h View 1 chunk +0 lines, -216 lines 0 comments Download
D src/ports/SkFontConfigParser_android.cpp View 1 chunk +0 lines, -797 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + src/ports/SkFontMgr_android_parser.h View 4 chunks +6 lines, -7 lines 0 comments Download
A + src/ports/SkFontMgr_android_parser.cpp View 7 chunks +13 lines, -14 lines 0 comments Download
D tests/FontConfigParser.cpp View 1 chunk +0 lines, -204 lines 0 comments Download
A + tests/FontMgrAndroidParserTest.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200103008/1
5 years, 6 months ago (2015-06-23 18:08:32 UTC) #2
bungeman-skia
Note that this will require a manual roll into Chromium, as this changes the names ...
5 years, 6 months ago (2015-06-23 18:09:08 UTC) #4
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-23 18:09:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200103008/20001
5 years, 6 months ago (2015-06-23 18:35:33 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-23 18:41:30 UTC) #10
djsollen
lgtm
5 years, 6 months ago (2015-06-23 19:48:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200103008/20001
5 years, 6 months ago (2015-06-23 20:25:13 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 20:25:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c53085413e0b4704aa89cc18396613d59e6ccb4d

Powered by Google App Engine
This is Rietveld 408576698