Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: Source/core/html/HTMLMarqueeElement.cpp

Issue 1200103006: Marquee width should not change a fixed width of its container. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMarqueeElement.cpp
diff --git a/Source/core/html/HTMLMarqueeElement.cpp b/Source/core/html/HTMLMarqueeElement.cpp
index a0d7155fc2dae621d930e2f32d0627de46b9b135..418e088f0c2afa2a1803d1df274df4774e168b90 100644
--- a/Source/core/html/HTMLMarqueeElement.cpp
+++ b/Source/core/html/HTMLMarqueeElement.cpp
@@ -71,4 +71,10 @@ void HTMLMarqueeElement::removedFrom(ContainerNode* insertionPoint)
}
}
+bool HTMLMarqueeElement::isHorizontal() const
+{
+ AtomicString direction = getAttribute(HTMLNames::directionAttr);
+ return direction != "down" && direction != "up";
mstensho (USE GERRIT) 2015/06/24 08:24:37 I suddenly started to wonder about the case-sensit
changseok 2015/06/25 06:41:34 I think that's a parser issue. Parser presumably i
mstensho (USE GERRIT) 2015/06/25 07:46:46 It's weird to be case-sensitive in this case, but
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698