Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: Source/core/layout/LayoutBlock.cpp

Issue 1200103006: Marquee width should not change a fixed width of its container. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutBlock.cpp
diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp
index c717f16cd731914f84449fa5e7454a712bf67b39..212549aa523f1d262696a76279d4f4d542d1cbec 100644
--- a/Source/core/layout/LayoutBlock.cpp
+++ b/Source/core/layout/LayoutBlock.cpp
@@ -2007,6 +2007,12 @@ void LayoutBlock::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Lay
maxLogicalWidth = std::max(minLogicalWidth, maxLogicalWidth);
+ if (!styleRef().autoWrap() && layer() && isHTMLMarqueeElement(node())) {
mstensho (USE GERRIT) 2015/06/23 09:33:30 What's with the layer() check? Also not sure why
changseok 2015/06/24 06:15:58 This is garbage code. This change is inspired by w
+ AtomicString direction = toElement(node())->getAttribute(directionAttr);
mstensho (USE GERRIT) 2015/06/23 09:33:31 I think I'd like to see this logic being moved to
changseok 2015/06/24 06:15:58 OK
+ if (direction != "down" && direction != "up")
+ minLogicalWidth = 0;
+ }
+
if (isTableCell()) {
Length tableCellWidth = toLayoutTableCell(this)->styleOrColLogicalWidth();
if (tableCellWidth.isFixed() && tableCellWidth.value() > 0)

Powered by Google App Engine
This is Rietveld 408576698