LayoutTests/fast/block/marquee-in-fixed-size-container.html - Issue 1200103006: Marquee width should not change a fixed width of its container.

Side by Side Diff: LayoutTests/fast/block/marquee-in-fixed-size-container.html

Issue 1200103006: Marquee width should not change a fixed width of its container. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	mstensho (USE GERRIT) 2015/06/24 08:24:37 I think we need a better file name. What's of inte I think we need a better file name. What's of interest here is the fact that we're measuring intrinsic minimum width. marquee-in-shrink-to-fit-in-fixed-size-container.html or something less ugly if you can think of something? changseok 2015/06/25 06:41:34 Renamed marquee-width-shrinks-to-fit-in-fixed-size Show quoted text On 2015/06/24 08:24:37, mstensho wrote: > I think we need a better file name. What's of interest here is the fact that > we're measuring intrinsic minimum width. > > marquee-in-shrink-to-fit-in-fixed-size-container.html or something less ugly if > you can think of something? Renamed marquee-width-shrinks-to-fit-in-fixed-size-container.html
	2 <script src="../../resources/js-test.js"></script>

	3 <style>

	4 div {
	mstensho (USE GERRIT) 2015/06/24 08:24:37 No need for this. DIVs don't have padding or margi No need for this. DIVs don't have padding or margin in the UA style sheet. changseok 2015/06/25 06:41:33 Removed. Show quoted text On 2015/06/24 08:24:37, mstensho wrote: > No need for this. DIVs don't have padding or margin in the UA style sheet. Removed.
	5 padding: 0px;

	6 margin: 0px;

	7 }

	8 .outer {

	9 width: 200px;

	10 }

	11 .inner {

	12 width: intrinsic;

	13 }

	14 </style>

	15 <div class="outer">

	16 <div class="inner">

	17 <marquee>The quick brown fox jumps over the lazy dog. The quick brown fox ju mps over the lazy dog. The quick brown fox jumps over the lazy dog.</marquee>

	18 </div>

	19 </div>

	20 <script>

	21 description("This tests if marquee contributes to the width of its container hav ing a fixed width size. It should not.");
	mstensho (USE GERRIT) 2015/06/24 08:24:37 This isn't quite right. It's not the container of This isn't quite right. It's not the container of the marquee that has fixed width: Its container is a shrink-to-fit container, which in turn lives in a width-constrained container. changseok 2015/06/25 06:41:34 How about this? "This tests if a block having an i Show quoted text On 2015/06/24 08:24:37, mstensho wrote: > This isn't quite right. It's not the container of the marquee that has fixed > width: Its container is a shrink-to-fit container, which in turn lives in a > width-constrained container. How about this? "This tests if a block having an intrinsic width and a marquee child collapses a fixed width of its container block. It should not." mstensho (USE GERRIT) 2015/06/25 07:46:46 I don't understand the word "collapses" in this co Show quoted text On 2015/06/25 06:41:34, changseok wrote: > On 2015/06/24 08:24:37, mstensho wrote: > > This isn't quite right. It's not the container of the marquee that has fixed > > width: Its container is a shrink-to-fit container, which in turn lives in a > > width-constrained container. > > How about this? > "This tests if a block having an intrinsic width and a marquee child collapses a > fixed width of its container block. It should not." I don't understand the word "collapses" in this context. How about: "Test that a horizontal marquee doesn't contribute to a container's intrinsic minimum width"
	22 shouldBeEqualToNumber("document.querySelector('.inner').getBoundingClientRect(). width", 200);

	23 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/block/marquee-in-fixed-size-container-expected.txt » ('j') | Source/core/html/HTMLMarqueeElement.cpp » ('J')