tools/gn/filesystem_utils.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/filesystem_utils.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/filesystem_utils.cc

diff --git a/tools/gn/filesystem_utils.cc b/tools/gn/filesystem_utils.cc

index 67bb6e256ee47ab29bd569499655f79c64ae2613..6e1c01d5e205f5a68b12d090a82713e4915e3a68 100644

--- a/tools/gn/filesystem_utils.cc

+++ b/tools/gn/filesystem_utils.cc

@@ -100,7 +100,7 @@ bool DoesBeginWindowsDriveLetter(const base::StringPiece& path) {

return false;

// Check drive letter.

- if (!IsAsciiAlpha(path[0]))

+ if (!base::IsAsciiAlpha(path[0]))

return false;

if (!IsSlash(path[2]))

« no previous file with comments | « tools/gn/command_args.cc ('k') | tools/gn/label.cc » ('j') | no next file with comments »