tools/gn/command_args.cc - Issue 1200053004: Move more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_args.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_args.cc

diff --git a/tools/gn/command_args.cc b/tools/gn/command_args.cc

index c4c16bbcbc3b303f09049785401e0fdde0fae9e9..518a1b69d3427c15e060e32820242d4369e49c46 100644

--- a/tools/gn/command_args.cc

+++ b/tools/gn/command_args.cc

@@ -37,7 +37,7 @@ const char kSwitchShort[] = "short";

bool DoesLineBeginWithComment(const base::StringPiece& line) {

// Skip whitespace.

size_t i = 0;

- while (i < line.size() && IsAsciiWhitespace(line[i]))

+ while (i < line.size() && base::IsAsciiWhitespace(line[i]))

i++;

return i < line.size() && line[i] == '#';

« no previous file with comments | « sync/util/get_session_name_mac.mm ('k') | tools/gn/filesystem_utils.cc » ('j') | no next file with comments »