Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7742)

Unified Diff: chrome/common/favicon/fallback_icon_url_parser.cc

Issue 1200053004: Move more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/favicon/fallback_icon_url_parser.cc
diff --git a/chrome/common/favicon/fallback_icon_url_parser.cc b/chrome/common/favicon/fallback_icon_url_parser.cc
index f91e39f6450d370b81c12160dd4d673306524b99..2f9467b271f7b9003df20953a5c70a88a72d8800 100644
--- a/chrome/common/favicon/fallback_icon_url_parser.cc
+++ b/chrome/common/favicon/fallback_icon_url_parser.cc
@@ -26,9 +26,10 @@ bool IsHexColorString(const std::string& color_str) {
const size_t* end = kValidHexColorSizes + arraysize(kValidHexColorSizes);
if (std::find(kValidHexColorSizes, end, len) == end)
return false;
- for (auto ch : color_str)
- if (!IsHexDigit(ch))
+ for (auto ch : color_str) {
+ if (!base::IsHexDigit(ch))
return false;
+ }
return true;
}
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router.cc ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698