Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1200043002: Revert of Oilpan: enable appcache + move DocumentLoader to the heap. (Closed)

Created:
5 years, 6 months ago by Stephen Chennney
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, tyoshino+watch_chromium.org, arv+blink, vivekg, eae+blinkwatch, Yoav Weiss, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, gavinp+loader_chromium.org, Inactive, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: enable appcache + move DocumentLoader to the heap. (patchset #11 id:190001 of https://codereview.chromium.org/1194003004/) Reason for revert: Linux Leak is failing on fast/html/imports/import-expando-gc.html, and this seems to be the most viable candidate for the cause. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/11999 and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fhtml%2Fimports%2Fimport-expando-gc.html&testType=layout-tests Original issue's description: > Oilpan: enable appcache + move DocumentLoader to the heap. > > DocumentLoader belongs on the heap. References to it > are kept by an object that is on the heap (FrameLoader), > and DocumentLoader itself has heap references. > > Along with moving DocumentLoader, have the two appcache > objects (ApplicationCache and ApplicationCacheHost) be > under Oilpan's control always. > > R=haraken > BUG=340522, 497595 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197576 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=340522, 497595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -179 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 5 chunks +12 lines, -15 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 13 chunks +20 lines, -40 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 5 chunks +3 lines, -14 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 11 chunks +19 lines, -24 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.cpp View 6 chunks +35 lines, -35 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebDataSourceImpl.h View 3 chunks +1 line, -5 lines 0 comments Download
M Source/web/WebDataSourceImpl.cpp View 2 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen Chennney
Created Revert of Oilpan: enable appcache + move DocumentLoader to the heap.
5 years, 6 months ago (2015-06-22 17:56:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200043002/1
5 years, 6 months ago (2015-06-22 17:57:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197585
5 years, 6 months ago (2015-06-22 17:58:30 UTC) #3
sof
Hmm, that's one flaky test http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fhtml%2Fimports%2Fimport-expando-gc.html
5 years, 6 months ago (2015-06-22 19:05:16 UTC) #4
sof
5 years, 6 months ago (2015-06-23 12:29:24 UTC) #5
Message was sent while issue was closed.
On 2015/06/22 19:05:16, sof wrote:
> Hmm, that's one flaky test
> 
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...

Filed https://code.google.com/p/chromium/issues/detail?id=503583 (and will put
up an attempted fix to stabilize the test.)

Powered by Google App Engine
This is Rietveld 408576698