Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1200033003: Date() should not depend on Date.prototype.toString (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Date() should not depend on Date.prototype.toString We used to call toString as a method which is not safe. BUG=v8:4225 LOG=Y R=adamk, littledan CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/6181ec9c2875d380e9abd0d24e386cc7fe2dd28c Cr-Commit-Position: refs/heads/master@{#29242}

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/date.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/date.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
arv (Not doing code reviews)
PTAL Last one for today
5 years, 6 months ago (2015-06-22 22:25:09 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-22 22:26:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200033003/1
5 years, 6 months ago (2015-06-23 21:33:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3673)
5 years, 6 months ago (2015-06-23 21:35:46 UTC) #6
arv (Not doing code reviews)
git rebase
5 years, 6 months ago (2015-06-23 21:38:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200033003/20001
5 years, 6 months ago (2015-06-23 21:39:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 23:18:37 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 23:18:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6181ec9c2875d380e9abd0d24e386cc7fe2dd28c
Cr-Commit-Position: refs/heads/master@{#29242}

Powered by Google App Engine
This is Rietveld 408576698