Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1200003002: Map::ReconfigureProperty() should mark map as unstable when it returns a different map. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Map::ReconfigureProperty() should mark map as unstable when it returns a different map. BUG=chromium:502930 LOG=N Committed: https://crrev.com/47421760f44dd8d2c92c92402655d85540513acf Cr-Commit-Position: refs/heads/master@{#29226}

Patch Set 1 : #

Patch Set 2 : Spurious changes in comments fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -15 lines) Patch
M src/objects.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-migrations.cc View 1 15 chunks +104 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-502930.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-23 09:07:25 UTC) #3
Toon Verwaest
lgtm minus test comments, the splits should be 2A / 2B as before afaict
5 years, 6 months ago (2015-06-23 10:57:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200003002/40001
5 years, 6 months ago (2015-06-23 11:06:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-23 11:30:45 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 11:31:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47421760f44dd8d2c92c92402655d85540513acf
Cr-Commit-Position: refs/heads/master@{#29226}

Powered by Google App Engine
This is Rietveld 408576698