src/x64/builtins-x64.cc - Issue 1199983002: [strong] Implement strong property access semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 1199983002: [strong] Implement strong property access semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add TODOs Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 6f7f6dac822780a9e8be3b3626406bd2a81f2f0a..fa957a1b67bef96dfdfa2dd1e5ab36d6144adb00 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -1142,7 +1142,8 @@ static void Generate_PushAppliedArguments(MacroAssembler* masm,

int index = feedback_vector->GetIndex(FeedbackVectorICSlot(0));

__ Move(slot, Smi::FromInt(index));

__ Move(vector, feedback_vector);

- Handle<Code> ic = KeyedLoadICStub(masm->isolate()).GetCode();

+ Handle<Code> ic =

+ KeyedLoadICStub(masm->isolate(), LoadICState(kNoExtraICState)).GetCode();

__ Call(ic, RelocInfo::CODE_TARGET);

// It is important that we do not have a test instruction after the

// call. A test instruction after the call is used to indicate that

« no previous file with comments | « src/runtime/runtime-object.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »