src/ic/ic-inl.h - Issue 1199983002: [strong] Implement strong property access semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic-inl.h

Issue 1199983002: [strong] Implement strong property access semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add TODOs Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic-inl.h

diff --git a/src/ic/ic-inl.h b/src/ic/ic-inl.h

index 95fbfc47549b095be57172e0d80a8dc4d34e2d52..b6ee6b13e53a812ddc0626cecf2604cbe90848d7 100644

--- a/src/ic/ic-inl.h

+++ b/src/ic/ic-inl.h

@@ -136,6 +136,9 @@ void LoadIC::set_target(Code* code) {

// The contextual mode must be preserved across IC patching.

DCHECK(LoadICState::GetContextualMode(code->extra_ic_state()) ==

LoadICState::GetContextualMode(target()->extra_ic_state()));

+ // Strongness must be preserved across IC patching.

+ DCHECK(LoadICState::GetLanguageMode(code->extra_ic_state()) ==

+ LoadICState::GetLanguageMode(target()->extra_ic_state()));

IC::set_target(code);

}

« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/ic-state.h » ('j') | no next file with comments »