Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1199933004: Factor clobber out of build/landmines.py (Closed)

Created:
5 years, 6 months ago by petrcermak
Modified:
5 years, 6 months ago
CC:
chromium-reviews, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor clobber out of build/landmines.py This patch factors clobbering functionality from build/landmines.py into build/clobber.py (new file). This will allow us to reuse existing code in the cr tool. BUG=493023 Committed: https://crrev.com/af7f4c0efa1389e3989041b3f50a9f647fe2d478 Cr-Commit-Position: refs/heads/master@{#335491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -82 lines) Patch
A build/clobber.py View 1 chunk +110 lines, -0 lines 0 comments Download
M build/landmines.py View 3 chunks +2 lines, -82 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
petrcermak
Hi, please review this patch. Thanks, Petr
5 years, 6 months ago (2015-06-22 12:32:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-22 12:34:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199933004/1
5 years, 6 months ago (2015-06-22 12:34:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 12:42:08 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 12:42:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af7f4c0efa1389e3989041b3f50a9f647fe2d478
Cr-Commit-Position: refs/heads/master@{#335491}

Powered by Google App Engine
This is Rietveld 408576698