Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: src/heap/heap.h

Issue 1199913002: Keep track of ArrayBuffers based on collector type, not space (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index db57591984d341f0c893b603deb2e760a63b9c73..de6b3856041cbbc276bcab41c909b1a66cc2f8f4 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1598,11 +1598,11 @@ class Heap {
void UnregisterArrayBuffer(bool in_new_space, void* data);
// A live ArrayBuffer was discovered during marking/scavenge.
- void RegisterLiveArrayBuffer(bool in_new_space, void* data);
+ void RegisterLiveArrayBuffer(bool from_scavenge, void* data);
// Frees all backing store pointers that weren't discovered in the previous
// marking or scavenge phase.
- void FreeDeadArrayBuffers(bool in_new_space);
+ void FreeDeadArrayBuffers(bool from_scavenge);
// Prepare for a new scavenge phase. A new marking phase is implicitly
// prepared by finishing the previous one.
@@ -2373,9 +2373,10 @@ class Heap {
bool concurrent_sweeping_enabled_;
Hannes Payer (out of office) 2015/06/22 12:54:23 Can we add comments to describe what these data st
std::map<void*, size_t> live_array_buffers_;
- std::map<void*, size_t> live_new_array_buffers_;
std::map<void*, size_t> not_yet_discovered_array_buffers_;
- std::map<void*, size_t> not_yet_discovered_new_array_buffers_;
+
+ std::map<void*, size_t> live_array_buffers_for_scavenge_;
+ std::map<void*, size_t> not_yet_discovered_array_buffers_for_scavenge_;
struct StrongRootsList;
StrongRootsList* strong_roots_list_;
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698