Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1199913002: Keep track of ArrayBuffers based on collector type, not space (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Keep track of ArrayBuffers based on collector type, not space Since Mark/Compact also collects garbage in the new space, we can't just free old space ArrayBuffers during MC - otherwise we run the risk of never freeing new array buffers BUG=v8:4201 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/839170e78536f2867ab6e42872dfa87bef0e5959 Cr-Commit-Position: refs/heads/master@{#29190}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -29 lines) Patch
M src/heap/heap.h View 1 2 2 chunks +18 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 2 4 chunks +42 lines, -24 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-22 08:39:34 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 6 months ago (2015-06-22 09:47:03 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1199913002/diff/20001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1199913002/diff/20001/src/heap/heap.h#newcode2374 src/heap/heap.h:2374: Can we add comments to describe what these ...
5 years, 6 months ago (2015-06-22 12:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199913002/40001
5 years, 6 months ago (2015-06-22 13:01:22 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-22 13:24:44 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 13:24:58 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/839170e78536f2867ab6e42872dfa87bef0e5959
Cr-Commit-Position: refs/heads/master@{#29190}

Powered by Google App Engine
This is Rietveld 408576698