Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1199903002: [turbofan] Some cleanup to the Typer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Some cleanup to the Typer. This change does the following: a.) Remove unused fields from the Typer. b.) Move some interesting unions to types.h. c.) Reduce Typer constructor overhead. d.) Avoid heap allocation in the Typer. R=jarin@chromium.org Committed: https://crrev.com/def2411a29b4796f0784462a200193c1305382a8 Cr-Commit-Position: refs/heads/master@{#29178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -126 lines) Patch
M src/compiler/typer.h View 1 chunk +19 lines, -32 lines 0 comments Download
M src/compiler/typer.cc View 19 chunks +85 lines, -93 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/types.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-22 08:08:31 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some more cleanup for the Typer. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-22 08:09:16 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-22 08:30:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199903002/1
5 years, 6 months ago (2015-06-22 09:14:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 09:15:58 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 09:16:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/def2411a29b4796f0784462a200193c1305382a8
Cr-Commit-Position: refs/heads/master@{#29178}

Powered by Google App Engine
This is Rietveld 408576698