Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119983002: convert cc logo to png to avoid unhandled mimetype in appengine (Closed)

Created:
7 years ago by Renato Mangini (chromium)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

convert cc logo to png to avoid unhandled mimetype in appengine Production AppEngine doesn't emit the proper mimetype for SVG automaticallly, requiring handling it in app code. To fix this bug, I just converted the CC logo to PNG. BUG=330040 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243961

Patch Set 1 #

Patch Set 2 : trying to fix binary issue with rietveld #

Patch Set 3 : trying to fix binary issue with rietveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -156 lines) Patch
A chrome/common/extensions/docs/static/images/cc_by.png View 2 Binary file 0 comments Download
D chrome/common/extensions/docs/static/images/cc_by.svg View 1 chunk +0 lines, -155 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/cc.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Renato Mangini (chromium)
Ready for review.
7 years ago (2013-12-20 15:52:15 UTC) #1
not at google - send to devlin
lgtm
7 years ago (2013-12-20 23:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/119983002/1
6 years, 11 months ago (2014-01-03 13:50:04 UTC) #3
commit-bot: I haz the power
Can't process patch for file chrome/common/extensions/docs/static/images/cc_by.png. Binary file is empty. Maybe the file wasn't uploaded ...
6 years, 11 months ago (2014-01-03 13:50:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/119983002/120001
6 years, 11 months ago (2014-01-03 14:10:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=37382
6 years, 11 months ago (2014-01-03 14:51:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/119983002/120001
6 years, 11 months ago (2014-01-03 14:58:03 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=37397
6 years, 11 months ago (2014-01-03 15:30:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/119983002/120001
6 years, 11 months ago (2014-01-03 18:52:24 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=37469
6 years, 11 months ago (2014-01-03 19:31:26 UTC) #10
not at google - send to devlin
You may need to dcommit binary files.
6 years, 11 months ago (2014-01-03 21:23:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/119983002/120001
6 years, 11 months ago (2014-01-09 19:59:07 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 20:02:48 UTC) #13
Message was sent while issue was closed. 
Change committed as 243961

Powered by Google App Engine
This is Rietveld 408576698