Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 1199813007: Convert base_unittests to Swarming everywhere. (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@6_ash_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert base_unittests to Swarming everywhere. Blacklist 'Linux GN (dbg)'. Ran: ./manage.py --convert base_unittests R=dpranke@chromium.org BUG=98637 Committed: https://crrev.com/1b7ce7cda949a08fedec8e53cdd45abd487440c5 Cr-Commit-Position: refs/heads/master@{#335745}

Patch Set 1 : rebase on 1195663002 #

Total comments: 7

Patch Set 2 : Blacklist Linux GN (dbg) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/tryserver.chromium.mac.json View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
M-A Ruel
https://codereview.chromium.org/1199813007/diff/20001/testing/buildbot/chromium.chromiumos.json File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/1199813007/diff/20001/testing/buildbot/chromium.chromiumos.json#newcode56 testing/buildbot/chromium.chromiumos.json:56: "can_use_on_swarming_builders": true I guess I should blacklist this builder ...
5 years, 6 months ago (2015-06-23 17:49:54 UTC) #2
Dirk Pranke
lgtm w/ the chromium.webkit change reverted. https://codereview.chromium.org/1199813007/diff/20001/testing/buildbot/chromium.chromiumos.json File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/1199813007/diff/20001/testing/buildbot/chromium.chromiumos.json#newcode56 testing/buildbot/chromium.chromiumos.json:56: "can_use_on_swarming_builders": true On ...
5 years, 6 months ago (2015-06-23 19:17:58 UTC) #3
M-A Ruel
https://codereview.chromium.org/1199813007/diff/20001/testing/buildbot/chromium.webkit.json File testing/buildbot/chromium.webkit.json (right): https://codereview.chromium.org/1199813007/diff/20001/testing/buildbot/chromium.webkit.json#newcode495 testing/buildbot/chromium.webkit.json:495: "can_use_on_swarming_builders": true On 2015/06/23 19:17:57, Dirk Pranke wrote: > ...
5 years, 6 months ago (2015-06-23 19:26:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199813007/40001
5 years, 6 months ago (2015-06-23 19:27:24 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 19:52:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199813007/40001
5 years, 6 months ago (2015-06-23 20:11:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-23 21:18:23 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1b7ce7cda949a08fedec8e53cdd45abd487440c5 Cr-Commit-Position: refs/heads/master@{#335745}
5 years, 6 months ago (2015-06-23 21:20:30 UTC) #13
jackhou1
5 years, 6 months ago (2015-06-23 23:25:15 UTC) #14
Message was sent while issue was closed.
On 2015/06/23 21:20:30, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/1b7ce7cda949a08fedec8e53cdd45abd487440c5
> Cr-Commit-Position: refs/heads/master@{#335745}

I think this may have broken the Mac ASan builder:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

Powered by Google App Engine
This is Rietveld 408576698