Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1199813004: i18n.js was not using original functions (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

i18n.js was not using original functions The i18n.js code was calling a lot of methods, which might have been removed or replaced by user code. Make sure we use the original functions. BUG=v8:4220 LOG=N R=adamk, littledan CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/51073d5f404354d89a3a988f8de28b1f0ea1b96a Cr-Commit-Position: refs/heads/master@{#29268}

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Add no variant tests to status file #

Patch Set 4 : Use match instead of exec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -70 lines) Patch
M src/array.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/i18n.js View 1 2 3 28 chunks +101 lines, -67 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/string.js View 1 2 3 4 chunks +13 lines, -3 lines 0 comments Download
A test/mjsunit/string-normalize.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-22 20:33:55 UTC) #1
adamk
lgtm +jochen FYI since he imported this code.
5 years, 6 months ago (2015-06-22 20:57:36 UTC) #2
arv (Not doing code reviews)
Fix typo
5 years, 6 months ago (2015-06-22 21:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199813004/20001
5 years, 6 months ago (2015-06-22 21:04:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/6882)
5 years, 6 months ago (2015-06-22 21:39:52 UTC) #8
arv (Not doing code reviews)
Add no variant tests to status file
5 years, 6 months ago (2015-06-22 22:10:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199813004/40001
5 years, 6 months ago (2015-06-22 22:11:21 UTC) #12
adamk
Can you explain the last patchset? Why did test behavior change with this patch?
5 years, 6 months ago (2015-06-22 22:21:45 UTC) #13
arv (Not doing code reviews)
On 2015/06/22 22:21:45, adamk wrote: > Can you explain the last patchset? Why did test ...
5 years, 6 months ago (2015-06-22 22:28:14 UTC) #15
arv (Not doing code reviews)
Use match instead of exec
5 years, 6 months ago (2015-06-24 19:48:42 UTC) #16
arv (Not doing code reviews)
On 2015/06/22 22:28:14, arv wrote: > On 2015/06/22 22:21:45, adamk wrote: > > Can you ...
5 years, 6 months ago (2015-06-24 19:49:49 UTC) #17
adamk
lgtm
5 years, 6 months ago (2015-06-24 19:51:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199813004/50001
5 years, 6 months ago (2015-06-24 19:52:37 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 6 months ago (2015-06-24 20:54:15 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 20:54:33 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/51073d5f404354d89a3a988f8de28b1f0ea1b96a
Cr-Commit-Position: refs/heads/master@{#29268}

Powered by Google App Engine
This is Rietveld 408576698