Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1199673003: Have enclosingPositionedAncestor() detect whether it walked past a certain ancestor. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Have enclosingPositionedAncestor() detect whether it walked past a certain ancestor. This is similar to what LayoutObject::container() does. This simplifies the code in accumulateOffsetTowardsAncestor(), which previously had to duplicate what enclosingPositionedAncestor() did. Also cleaned up the other call site of enclosingPositionedAncestor(). No need to call the method twice there. No behavioral changes intended; this is just clean-up. R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197846

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M Source/core/paint/DeprecatedPaintLayer.h View 1 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 3 chunks +18 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-23 12:32:49 UTC) #1
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-25 17:26:06 UTC) #2
chrishtr
https://codereview.chromium.org/1199673003/diff/1/Source/core/paint/DeprecatedPaintLayer.h File Source/core/paint/DeprecatedPaintLayer.h (right): https://codereview.chromium.org/1199673003/diff/1/Source/core/paint/DeprecatedPaintLayer.h#newcode200 Source/core/paint/DeprecatedPaintLayer.h:200: DeprecatedPaintLayer* enclosingPositionedAncestor(const DeprecatedPaintLayer* ancestor = nullptr, bool* skippedAncestor = ...
5 years, 6 months ago (2015-06-25 17:32:58 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/1199673003/diff/1/Source/core/paint/DeprecatedPaintLayer.h File Source/core/paint/DeprecatedPaintLayer.h (right): https://codereview.chromium.org/1199673003/diff/1/Source/core/paint/DeprecatedPaintLayer.h#newcode200 Source/core/paint/DeprecatedPaintLayer.h:200: DeprecatedPaintLayer* enclosingPositionedAncestor(const DeprecatedPaintLayer* ancestor = nullptr, bool* skippedAncestor = ...
5 years, 6 months ago (2015-06-25 18:04:13 UTC) #4
chrishtr
lgtm
5 years, 6 months ago (2015-06-25 18:05:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199673003/20001
5 years, 6 months ago (2015-06-25 18:05:55 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 19:05:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197846

Powered by Google App Engine
This is Rietveld 408576698