Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119963004: Manage all the testing classes for Blacklist in TestBlacklist. (Closed)

Created:
7 years ago by Oleg Eterevsky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Manage all the testing classes for Blacklist in TestBlacklist. BUG=267514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244178

Patch Set 1 #

Total comments: 13

Patch Set 2 : Rebase, fix small issues. #

Patch Set 3 : Fix memory error and add a comment. #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -93 lines) Patch
M chrome/browser/extensions/blacklist.h View 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/blacklist.cc View 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/blacklist_unittest.cc View 1 9 chunks +21 lines, -69 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 8 chunks +28 lines, -18 lines 0 comments Download
M chrome/browser/extensions/fake_safe_browsing_database_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/fake_safe_browsing_database_manager.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/test_blacklist.h View 1 2 3 4 1 chunk +66 lines, -1 line 0 comments Download
M chrome/browser/extensions/test_blacklist.cc View 1 2 3 3 chunks +102 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Oleg Eterevsky
7 years ago (2013-12-20 17:56:09 UTC) #1
not at google - send to devlin
lgtm https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/blacklist.h File chrome/browser/extensions/blacklist.h (right): https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/blacklist.h#newcode102 chrome/browser/extensions/blacklist.h:102: BlacklistStateFetcher* ResetBlacklistStateFetcherForTest(); return a scoped_ptr<BlacklistStateFetcher> here. https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/test_blacklist.cc File ...
7 years ago (2013-12-21 00:34:24 UTC) #2
Oleg Eterevsky
https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/blacklist.h File chrome/browser/extensions/blacklist.h (right): https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/blacklist.h#newcode102 chrome/browser/extensions/blacklist.h:102: BlacklistStateFetcher* ResetBlacklistStateFetcherForTest(); On 2013/12/21 00:34:24, kalman wrote: > return ...
6 years, 11 months ago (2014-01-09 13:54:01 UTC) #3
Oleg Eterevsky
https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/blacklist.h File chrome/browser/extensions/blacklist.h (right): https://chromiumcodereview.appspot.com/119963004/diff/1/chrome/browser/extensions/blacklist.h#newcode102 chrome/browser/extensions/blacklist.h:102: BlacklistStateFetcher* ResetBlacklistStateFetcherForTest(); On 2013/12/21 00:34:24, kalman wrote: > return ...
6 years, 11 months ago (2014-01-09 17:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/119963004/190001
6 years, 11 months ago (2014-01-09 17:59:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=209886
6 years, 11 months ago (2014-01-09 18:17:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/119963004/480001
6 years, 11 months ago (2014-01-09 19:05:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=209935
6 years, 11 months ago (2014-01-09 19:34:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/119963004/720001
6 years, 11 months ago (2014-01-10 10:49:38 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) check_deps2git http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=190205
6 years, 11 months ago (2014-01-10 12:09:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/119963004/790002
6 years, 11 months ago (2014-01-10 14:31:34 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 17:03:21 UTC) #12
Message was sent while issue was closed. 
Change committed as 244178

Powered by Google App Engine
This is Rietveld 408576698